Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precondition in comments/commentThread/context doesn't seem to work #74541

Closed
dbaeumer opened this issue May 29, 2019 · 1 comment
Closed

Precondition in comments/commentThread/context doesn't seem to work #74541

dbaeumer opened this issue May 29, 2019 · 1 comment
Assignees
@RMacfarlane
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
May 2019

Comments

@dbaeumer
Copy link
Member

Testing #74472

I added the following command to the comments/commentThread/context:

					"command": "mywiki.createDocument",
					"group": "inline",
					"precondition": "commentIsEmpty",
					"when": "commentThreadIsEmpty"
				}

However the command is not disabled (visually) when the comment changes from empty to non empty
@dbaeumer dbaeumer assigned dbaeumer and RMacfarlane and unassigned dbaeumer May 29, 2019
@RMacfarlane
Copy link
Contributor

"precondition" was renamed to "enablement", updated the sample

@RMacfarlane RMacfarlane mentioned this issue May 29, 2019
Closed
@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label May 29, 2019
@RMacfarlane RMacfarlane added this to the May 2019 milestone May 29, 2019
@mjbvz mjbvz added the verified Verification succeeded label May 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
May 2019
Development

No branches or pull requests
3 participants
@dbaeumer @RMacfarlane @mjbvz