Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict null check extHostTask #70414

Closed
mjbvz opened this issue Mar 13, 2019 · 1 comment
Closed

Strict null check extHostTask #70414

mjbvz opened this issue Mar 13, 2019 · 1 comment
Assignees
@alexr00
Labels
debt Code quality issues
Milestone
March 2019

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Mar 13, 2019 •
edited
Loading

vs/workbench/api/node/extHostTask.ts is strict null check eligible. It has around 34 errors (~10% of the remaining strict errors in VS Code)

For #60565
@mjbvz mjbvz added the debt Code quality issues label Mar 13, 2019
@dbaeumer dbaeumer removed their assignment Mar 13, 2019
@alexr00 alexr00 added this to the March 2019 milestone Mar 14, 2019
@alexr00
Copy link
Member

alexr00 commented Mar 14, 2019

@mjbvz I did the file, but it needs to stay commented out in tsconfig.strictNullChecks.json until the files it depends on are done.

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
debt Code quality issues
Projects
None yet
Milestone
March 2019
Development

No branches or pull requests
3 participants
@dbaeumer @mjbvz @alexr00