Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict null check vs/workbench/contrib/tasks #69685

Closed
mjbvz opened this issue Mar 2, 2019 · 0 comments
Closed

Strict null check vs/workbench/contrib/tasks #69685

mjbvz opened this issue Mar 2, 2019 · 0 comments
Assignees
Labels
debt Code quality issues tasks Task system issues
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Mar 2, 2019

Part of #60565

Tracks updating vs/workbench/contrib/tasks to have strict null checking.

Not all of these files are eligible to be included in the strict null build yet due to their dependencies. You do not need to fix errors outside of the contrib/tasks directory

Steps

  1. Add ./vs//workbench/contrib/tasks/**/*.ts to the include section of src/tsconfig.strictNullChecks.json
  2. Run yarn strict-null-check -- --watch
  3. Fix strict null check compiler errors inside of the contrib/tasks directory.
  4. Verify normal build still works
  5. Revert changes to src/tsconfig.strictNullChecks.json
@mjbvz mjbvz added the debt Code quality issues label Mar 2, 2019
@alexr00 alexr00 added this to the March 2019 milestone Mar 4, 2019
@alexr00 alexr00 added the tasks Task system issues label Mar 4, 2019
@dbaeumer dbaeumer removed their assignment Mar 4, 2019
@alexr00 alexr00 closed this as completed in 977f414 Mar 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues tasks Task system issues
Projects
None yet
Development

No branches or pull requests

3 participants