Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict null check vs/workbench/services/configurationResolver #69683

Closed
mjbvz opened this issue Mar 2, 2019 · 1 comment
Closed

Strict null check vs/workbench/services/configurationResolver #69683

mjbvz opened this issue Mar 2, 2019 · 1 comment
Assignees
Labels
debt Code quality issues
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Mar 2, 2019

Part of #60565

Tracks updating vs/workbench/services/configurationResolver to have strict null checking.

Not all of these files are eligible to be included in the strict null build yet due to their dependencies. You do not need to fix errors outside of the configurationResolver directory

Steps

  1. Add ./vs/workbench/services/configurationResolver/**/*.ts to the include section of src/tsconfig.strictNullChecks.json
  2. Run yarn strict-null-check -- --watch
  3. Fix strict null check compiler errors inside of the configurationResolver dir.
  4. Verify normal build still works
  5. Revert changes to src/tsconfig.strictNullChecks.json
@mjbvz mjbvz added the debt Code quality issues label Mar 2, 2019
@mjbvz mjbvz added this to the March 2019 milestone Mar 19, 2019
@mjbvz
Copy link
Collaborator Author

mjbvz commented Mar 19, 2019

Adding this to march since there are only around 30 strict null errors left in the codebase

@vscodebot vscodebot bot locked and limited conversation to collaborators May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

2 participants