Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parts of serverReadyAction should be contributed by chrome debug #69339

Closed
isidorn opened this issue Feb 25, 2019 · 2 comments
Closed

Parts of serverReadyAction should be contributed by chrome debug #69339

isidorn opened this issue Feb 25, 2019 · 2 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality under-discussion Issue is under discussion for relevance, priority, approach

Comments

@isidorn
Copy link
Contributor

isidorn commented Feb 25, 2019

Refs #69313

It feels like parts of the serverReadyAction are tightly coupled with the chrome debug extension.
Due to that I feel like those attributes should be contributed from the chrome debug extension - since they do not really make sense if the chrome debug extension is not installed.
An example of such an attribute is webRoot.
Another is the "action": "debugWithChrome"

If we allow these attributes to be contributed by the chrome extension it should make it easier to integrate this for other browser debug extensions like firefox.

@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Feb 25, 2019
@weinand weinand added the feature-request Request for new features or functionality label Feb 25, 2019
@weinand
Copy link
Contributor

weinand commented Feb 25, 2019

Yes, that's the discussion we are having here: microsoft/debug-adapter-protocol#23 (comment)

@weinand weinand added the under-discussion Issue is under discussion for relevance, priority, approach label Feb 26, 2019
@weinand weinand added this to the On Deck milestone Feb 26, 2019
@weinand weinand assigned connor4312 and unassigned weinand Oct 19, 2022
@weinand weinand modified the milestones: On Deck, Backlog Oct 19, 2022
@connor4312
Copy link
Member

A while ago I added a "startDebugging" action which allows the user to name another launch configuration they want to invoke, which can be Firefox or any other debug configuration they would like to launch.

(technically it could make arbitrary chained launch configurations, they don't even have to be browsers...)

@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

4 participants