Actions in the debug toolbar should be properly contributed

[isidorn]

The base debug actions should also be contributed via menu registry.
To allow intermingling with actions contributed by extensions.

[DanTup]

To allow intermingling with actions contributed by extensions.

It'd be good to ensure this can work consistently with the touch bar too. When I tried to add buttons in between (using group 9_debug or something) the spaces between the buttons disappeared and it all became a mess.

Specifically I'm interested in adding a "hot reload" button next to the "restart" button both in the touch bar and debug toolbar :-)

[isidorn]

Also as part of this we should support rendering separators in the debug toolbar.
@bpasero @misolori do we already have some horizontal seperator somewhere that I can reuse? Not to my knowledge.

[bpasero]

@isidorn I don't think so, besides maybe the custom menu which has separators horizontally

[isidorn]

Now all the debug actions are properly contribued using groups and orders.
All the debug commands are in the navigation group which is primary. Now it is possible to also insert items in between the built in debug commands. @DanTup try it out and let us know. You can use the order, here are the orders that debug commands use https://github.com/Microsoft/vscode/blob/05f926991c9c52dff838d542c0014acd756833e2/src/vs/workbench/contrib/debug/electron-browser/debug.contribution.ts#L262

Adding feature request label so I mention this in the relase notes.

[DanTup]

@isidorn Cool, thanks! I'll take a look in Insiders later in the week :-)

Do you know off-hand whether I should be able to do the same for TouchBar (I know it's not part of this work, but I'm not sure if it's expected to work - as when I tried, strange things happened, like missing dividers between buttons). If it's supposed to work, I'll repro and open bugs, otherwise I'll open a request to support it there too.

Thanks!

[isidorn]

This is currently not supported for the TouchBar.
If you would like this please open a feature request (thought not sure if we will tackle it)

[DanTup]

@isidorn LGTM, thanks!

I opened new issues about the Touch Bar (#70737 and #70735).

[isidorn]

@DanTup great that it works for you!