Pull request Treeview ThemeIcon returns exception

[st-schneider]

Issue Type: Bug

when I try to look up the changed files I get this.

Extension version: 0.4.0
VS Code version: Code - Insiders 1.32.0-insider (7ff2398, 2019-02-11T11:40:52.304Z)
OS version: Darwin x64 17.7.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz (8 x 2800)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	3, 3, 3
Memory (System)	16.00GB (0.05GB free)
Process Argv	-psn_0_19132990
Screen Reader	no
VM	0%

[st-schneider]

[rebornix]

We can see the same exception when running Find All References, which probably use ThemeIcon as well.

While debugging the extension I found

Above explains why iconPath instanceof ThemeIcon is always false https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/api/node/extHostTreeViews.ts#L473

[rebornix]

It seems #68121 is the trigger.

[vscodebot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!