-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Welcome page extension suggestions should not be hardcoded into our source code #67600
Comments
The problem with making this configurable is / might be that the UI doesn't scale well, so one has to be careful not to put too many extensions in. Do you have a specific use case in mind? |
When I updated our recommendations to recommend the new tslint-plugin extension instead of the Also I don't think we should be referencing VS marketplace extensions in OSS builds |
No longer using that list. We do have the SVG's of extensions with clickable links, I suppose we could pull those into |
Do we need to move all of the walkthroughs over to distro then? The only items that would be applicable to the marketplace is extensions and there's a few spots where we mix those in. |
Hm, I think this could be a good use case for product-specific tiles, as we want to avoid any code patches in |
We no longer recommend extensions in the welcome page. |
Issue Type: Bug
Bug
On the welcome page, we hardcode some recommended extensions for the
Tools and languages
section.Request
Pull these recommendations from the
product.json
insteadVS Code version: Code - Insiders 1.31.0-insider (9606490, 2019-01-30T15:15:08.172Z)
OS version: Darwin x64 18.2.0
System Info
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
The text was updated successfully, but these errors were encountered: