Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome page extension suggestions should not be hardcoded into our source code #67600

Closed
mjbvz opened this issue Jan 31, 2019 · 6 comments
Closed
Assignees
Labels
engineering VS Code - Build / issue tracking / etc. feature-request Request for new features or functionality getting-started

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 31, 2019

Issue Type: Bug

Bug
On the welcome page, we hardcode some recommended extensions for the Tools and languages section.

Request
Pull these recommendations from the product.json instead

VS Code version: Code - Insiders 1.31.0-insider (9606490, 2019-01-30T15:15:08.172Z)
OS version: Darwin x64 18.2.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 3
Memory (System) 16.00GB (0.30GB free)
Process Argv -psn_0_20636589
Screen Reader no
VM 22%
@chrmarti
Copy link
Contributor

The problem with making this configurable is / might be that the UI doesn't scale well, so one has to be careful not to put too many extensions in.

Do you have a specific use case in mind?

@chrmarti chrmarti added workbench-welcome Welcome page issues under-discussion Issue is under discussion for relevance, priority, approach labels Jan 31, 2019
@mjbvz
Copy link
Collaborator Author

mjbvz commented Jan 31, 2019

When I updated our recommendations to recommend the new tslint-plugin extension instead of the eg2.tslint extension, I missed updating the reference to the old tslint extension on the welcome page.

Also I don't think we should be referencing VS marketplace extensions in OSS builds

@chrmarti chrmarti added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Oct 24, 2019
@JacksonKearl
Copy link
Contributor

JacksonKearl commented Oct 22, 2021

No longer using that list. We do have the SVG's of extensions with clickable links, I suppose we could pull those into -distro a la. the other product images. cc @digitarald @misolori

@JacksonKearl JacksonKearl added this to the Backlog milestone Oct 22, 2021
@JacksonKearl JacksonKearl added getting-started and removed workbench-welcome Welcome page issues labels Oct 22, 2021
@miguelsolorio
Copy link
Contributor

Do we need to move all of the walkthroughs over to distro then? The only items that would be applicable to the marketplace is extensions and there's a few spots where we mix those in.

@JacksonKearl JacksonKearl added engineering VS Code - Build / issue tracking / etc. feature-request Request for new features or functionality and removed feature-request Request for new features or functionality labels Oct 25, 2021
@JacksonKearl
Copy link
Contributor

Hm, I think this could be a good use case for product-specific tiles, as we want to avoid any code patches in distro going forward.... some sort of product.json/embedder API to provide additional tiles would be nice to have here.

@bhavyaus bhavyaus assigned bhavyaus and unassigned lramos15 Dec 8, 2022
@bhavyaus
Copy link
Collaborator

We no longer recommend extensions in the welcome page.

@bhavyaus bhavyaus closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2023
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc. feature-request Request for new features or functionality getting-started
Projects
None yet
Development

No branches or pull requests

7 participants