Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug N PHP applications: step over jumps to wrong one #6757

Closed
bpasero opened this issue May 24, 2016 · 5 comments
Closed

Debug N PHP applications: step over jumps to wrong one #6757

bpasero opened this issue May 24, 2016 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented May 24, 2016

Refs: #6160

If you debug multiple PHP scripts at once, and step over a line in the one script, the other script gets revealed in the stackframe view.

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label May 24, 2016
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label May 24, 2016
@isidorn isidorn added this to the May 2016 milestone May 24, 2016
@isidorn
Copy link
Contributor

isidorn commented May 25, 2016

This is happening because the php adapter is first sending a stopped event before the response for step returns. I have created an issue for the PHP adapter here xdebug/vscode-php-debug#37
Previously we had a workaround that would prevent this issue, but we have remoed this workaround due to other issues #5966

@isidorn isidorn closed this as completed May 25, 2016
@isidorn isidorn assigned bpasero and unassigned isidorn May 25, 2016
@isidorn isidorn added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label May 25, 2016
@bpasero bpasero assigned weinand and unassigned bpasero May 26, 2016
@bpasero
Copy link
Member Author

bpasero commented May 26, 2016

@isidorn would appreciate if @weinand could verify on your machine because I am out until next week

@isidorn
Copy link
Contributor

isidorn commented May 26, 2016

@bpasero there is still nothing to verify since we depend on the PHP debugger on this one

@bpasero
Copy link
Member Author

bpasero commented May 26, 2016

Ah ok.

@weinand weinand modified the milestones: June 2016, May 2016 May 27, 2016
@weinand weinand assigned bpasero and unassigned weinand May 27, 2016
@weinand
Copy link
Contributor

weinand commented May 27, 2016

assigning for verification back to @bpasero

@weinand weinand added the verified Verification succeeded label Jul 4, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants