Skip to content

Assign keyboard shortcut for filter on type mode toggle #66899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isidorn opened this issue Jan 22, 2019 · 3 comments
Closed

Assign keyboard shortcut for filter on type mode toggle #66899

isidorn opened this issue Jan 22, 2019 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality list-widget List widget issues

Comments

@isidorn
Copy link
Contributor

isidorn commented Jan 22, 2019

Two options I see here:

  1. Steal Cmd + F to no longer open find widget while the focus is in the list.
  2. Use some obscure shortcut like a key chord

I would go with 1) as the filter widget is more scoped find widget, and I think it should replace the cmd + F
When this command is triggered I would expect the widget to expand for some time.

@isidorn isidorn added the list-widget List widget issues label Jan 22, 2019
@joaomoreno
Copy link
Member

Steal Cmd + F to no longer open find widget while the focus is in the list.

I would not do this. You should start to think about an Explorer/Search integration and you will definitely want to have Cmd F for this.

@joaomoreno joaomoreno added this to the December/January 2019 milestone Jan 23, 2019
@joaomoreno joaomoreno added the feature-request Request for new features or functionality label Jan 23, 2019
@joaomoreno joaomoreno changed the title Assign keyboard shortcut for filter on type toggle Assign keyboard shortcut for filter on type mode toggle Jan 25, 2019
@joaomoreno
Copy link
Member

We should at least add a command.

@joaomoreno
Copy link
Member

Added command: list.toggleFilterOnType.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality list-widget List widget issues
Projects
None yet
Development

No branches or pull requests

2 participants