Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom indent in trees: exclude first level #66863

Closed
usernamehw opened this issue Jan 21, 2019 · 6 comments
Closed

Custom indent in trees: exclude first level #66863

usernamehw opened this issue Jan 21, 2019 · 6 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues verified Verification succeeded
Milestone
December/January ...

Comments

@usernamehw
Copy link
Contributor

Issue Type: Feature Request

#35447

Keep first level indentation at 8px.

VS Code version: Code - Insiders 1.31.0-insider (e9bb33f, 2019-01-21T06:19:35.291Z)
OS version: Windows_NT x64 10.0.17763
@vscodebot vscodebot bot added the editor-autoindent Editor auto indentation issues label Jan 21, 2019
@sandy081 sandy081 added feature-request Request for new features or functionality tree-views Extension tree view issues and removed editor-autoindent Editor auto indentation issues labels Jan 22, 2019
@sandy081 sandy081 self-assigned this Jan 22, 2019
@sandy081
Copy link
Member

This will be taken care when custom views adopt to new tree.

@sandy081 sandy081 added this to the Backlog milestone Jan 22, 2019
@usernamehw
Copy link
Contributor Author

@sandy081, but this is about all trees (for instance Explorer now moves 1st level with "workbench.tree.indent").

@sandy081
Copy link
Member

Internally there are two types of tree implementation old and new. We are currently adopting to new tree one by one. Explorer has done it this milestone. These configurations you mentioned belongs to new workbench tree. Custom view trees are still on old tree implementation.

@usernamehw usernamehw changed the title Custom tree indent: exclude first level Custom indent in trees: exclude first level Jan 23, 2019
@usernamehw
Copy link
Contributor Author

usernamehw commented Jan 23, 2019 •
edited
Loading

I guess the title was confusing. I'm talking about the new tree indent wherever it applied. Currently in Explorer. In future in all other trees it shouldn't affect the first (initial) level of items.

@sandy081 sandy081 assigned isidorn and unassigned sandy081 Jan 23, 2019
@sandy081 sandy081 removed tree-views Extension tree view issues feature-request Request for new features or functionality labels Jan 23, 2019
@sandy081 sandy081 removed this from the Backlog milestone Jan 23, 2019
@sandy081
Copy link
Member

Sorry for the confusion, assigned to right owner.

@isidorn
Copy link
Contributor

isidorn commented Jan 23, 2019 •
edited
Loading

This makes sense. Forwarding to @joaomoreno since it is for all trees

@isidorn isidorn assigned joaomoreno and unassigned isidorn Jan 23, 2019
@joaomoreno joaomoreno added this to the December/January 2019 milestone Jan 24, 2019
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues labels Jan 24, 2019
@sandy081 sandy081 added the verified Verification succeeded label Jan 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues verified Verification succeeded
Projects
None yet
Milestone
December/January 2019
Development

No branches or pull requests
4 participants
@joaomoreno @isidorn @usernamehw @sandy081