Skip to content

URL containing + not properly detected in integrated terminal #66182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aarongable opened this issue Jan 7, 2019 · 2 comments
Closed

URL containing + not properly detected in integrated terminal #66182

aarongable opened this issue Jan 7, 2019 · 2 comments
Assignees
@Tyriar
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label

Comments

@aarongable
Copy link

Steps to reproduce:
1) Open the integrated terminal
2) Run a command whose output includes a url which contains a "+". For example:

$ git push gerrit
remote: Processing changes: refs: 1, new: 1, done
remote:
remote: SUCCESS
remote:
remote: New Changes:
remote:   https://chromium-review.googlesource.com/c/chromium/src/+/1399451 Make install-build-deps more obvious in docs [WIP]
To https://chromium.googlesource.com/chromium/src
 * [new branch]                53883d70c2460778176a32b07297ba7ab43d690f -> refs/for/refs/heads/master

3) Try to ctrl+click the link which contains a +

Expected result:
4) The whole url is detected

Actual result:
4) Only the url up to but not including the + is detected. The rest ("+/1399451") is ignored.

screenshot
@vscodebot
Copy link

vscodebot bot commented Jan 7, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Jan 7, 2019
@Tyriar Tyriar mentioned this issue Jan 8, 2019
Closed
@Tyriar
Copy link
Member

Tyriar commented Jan 8, 2019

Merged into #21125

@Tyriar Tyriar closed this as completed Jan 8, 2019
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 8, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tyriar @aarongable