Terminal in Solarized Dark theme seems to have

[totkeks]

I recently upgraded my PowerShell on Windows to use the Solarized colors as well. For this I found this repository https://github.com/neilpa/cmd-colors-solarized. They also provide a script to show all the current console colors and their mapping to the respective Solarized dark/light colors.

When comparing both I noticed, that the colors in the Powershell terminal inside VS Code where off.
Inside VS code:

Regular powershell:

Do they both use different mappings of the Solarized colors to the 16 console colors or does the terminal inside VS Code just works entirely differently?

• VSCode Version: 1.29.1
• OS Version: Win10 1809

Steps to Reproduce:

1. Select the Solarized Dark theme for VS Code
2. Open the terminal with the powershell shell
3. Run the script Out-Colors.ps1 from https://github.com/neilpa/cmd-colors-solarized

[Tyriar]

The VS Code terminal does work a little differently, I'd suggest we hold off on this investigation until conpty ships which should have much more correct colors (see #45693, microsoft/node-pty#216)

[totkeks]

Thanks for the quick reply! Your suggestion sounds good. Looking forward to it in future versions.