Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tree type-navigation support #64233

Closed
joaomoreno opened this issue Dec 3, 2018 · 6 comments
Closed

Implement tree type-navigation support #64233

joaomoreno opened this issue Dec 3, 2018 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan tree-widget Tree widget issues

Comments

@joaomoreno
Copy link
Member

A tree should be navigable by typing letters which match the row labels, similarly to file explorers.

cc @weinand @isidorn @sandy081 @jrieken

@joaomoreno joaomoreno added feature-request Request for new features or functionality tree-widget Tree widget issues labels Dec 3, 2018
@joaomoreno joaomoreno added this to the December 2018 milestone Dec 3, 2018
@joaomoreno joaomoreno self-assigned this Dec 3, 2018
@jrieken
Copy link
Member

jrieken commented Dec 3, 2018

@joaomoreno
Copy link
Member Author

joaomoreno commented Dec 3, 2018

Thanks!

Edit: links are broken tho :P

@jrieken
Copy link
Member

jrieken commented Dec 3, 2018

links are broken tho :P

Needed to push

@joaomoreno
Copy link
Member Author

Here's a cool demo:

peek 2018-12-12 08-36

This feature is now available for all lists and new trees. You still need to provide a TypeLabelProvider when creating your list/tree, just like what @isidorn has done for debug in 64addbd.

@weinand
Copy link
Contributor

weinand commented Dec 12, 2018

@joaomoreno Cool feature, but the name TypeLabelProvider is a bit misleading.
And KeyboardNavigationLabelProvider is a bit long...

@joaomoreno
Copy link
Member Author

Went with KeyboardNavigationLabelProvider, not really worried about the length. 👍

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan tree-widget Tree widget issues
Projects
None yet
Development

No branches or pull requests

3 participants