Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributes.html.customTags and contributes.html.customAttributes #64022

Closed
octref opened this issue Nov 29, 2018 · 1 comment
Closed

Add contributes.html.customTags and contributes.html.customAttributes #64022

octref opened this issue Nov 29, 2018 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality html HTML support issues on-testplan

Comments

@octref
Copy link
Contributor

octref commented Nov 29, 2018

Continuation of #62976.

These contribution points should be similar to the user configurations:

{
  "html.experimental.custom.tags": [
    "./web-components.json",
    "./element-details/web-components.json"
  ],
  "html.experimental.custom.attributes": [
    "./web-component-attributes.json"
  ]
}

They allow extension authors to publish a list of tags / attributes together with its frameworks, and VS Code could load them for HTML language features.

@octref
Copy link
Contributor Author

octref commented Jan 28, 2019

We are shipping this instead:

"contributes": {
	"html": {
		"customData": [
			"./data/svg-html-contribution.json"
		]
	},
}

@octref octref modified the milestones: Backlog, December/January 2019 Jan 28, 2019
@octref octref added the feature-request Request for new features or functionality label Jan 28, 2019
@octref octref closed this as completed in 33783ba Jan 28, 2019
@dbaeumer dbaeumer added the verification-needed Verification of issue is requested label Jan 29, 2019
@octref octref added on-testplan and removed verification-needed Verification of issue is requested labels Jan 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality html HTML support issues on-testplan
Projects
None yet
Development

No branches or pull requests

2 participants