Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCRE2 search does not support \u{0061} in regex #62416

Closed
mjbvz opened this issue Nov 1, 2018 · 3 comments · Fixed by microsoft/azuredatastudio#7206
Closed

PCRE2 search does not support \u{0061} in regex #62416

mjbvz opened this issue Nov 1, 2018 · 3 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 1, 2018

Issue Type: Bug

Testing #61744

Repo

  1. Enable pcre2 search
  2. Open search and enable regular expression search
  3. Search for \u{0061} (a)

Bug
No search results.

If you disable pcre2 search and search then you get the expected results. \x{0061} does work with PCRE2

VS Code version: Code - Insiders 1.29.0-insider (d7ac6e8, 2018-11-01T06:11:43.390Z)
OS version: Darwin x64 18.0.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 4, 3, 3
Memory (System) 16.00GB (0.05GB free)
Process Argv -psn_0_52474376
Screen Reader no
VM 22%
@roblourens
Copy link
Member

roblourens commented Nov 1, 2018

I remap \u1234 to \x1234 but not \u{1234} because it isn't supported by JS correctly yet.

> /\u{0061}/.test(Array(62).join('u'))
true

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Nov 1, 2018
@roblourens
Copy link
Member

Also see #61746

@vscodebot vscodebot bot removed the insiders label Dec 13, 2018
@roblourens roblourens added this to the July 2019 milestone Jul 2, 2019
@roblourens
Copy link
Member

Requires #61746

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants