Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[themes] Allow textmate token color customizations to reference existing scope #62201

Closed
0xc0 opened this issue Oct 30, 2018 · 3 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code themes Color theme issues
Milestone

Comments

@0xc0
Copy link

0xc0 commented Oct 30, 2018

Allow the ability to reference an existing token

Use case

Instead of needing to have

  "editor.tokenColorCustomizations": {
    "[Default Dark+]": {
      "textMateRules": [
        {
          "scope": "markup.italic",
          "settings": {
            "foreground": "#dcdcaa"
          }
        }
      ]
    },
    "[Default Light+]": {
      "textMateRules": [
        {
          "scope": "markup.italic",
          "settings": {
            "foreground": "#795e26"
          }
        }
      ]
    }
  }

in which the foreground color is copied from the support.function foreground color of each theme and repeating for each theme, something similar to the following:

  "editor.tokenColorCustomizations": {
    "textMateRules": [
      {
        "scope": "markup.italic",
        "settings": {
          "foreground": {
            "referenceScope": "support.function",
            "referenceSetting": "foreground"
          }
        }
      }
    ]
  }
@vscodebot
Copy link

vscodebot bot commented Oct 30, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the themes Color theme issues label Oct 30, 2018
@alexdima alexdima assigned aeschli and unassigned alexdima Oct 31, 2018
@aeschli aeschli changed the title Allow textmate token color customizations to reference existing scope [themes] Allow textmate token color customizations to reference existing scope Jan 8, 2019
@aeschli aeschli added the feature-request Request for new features or functionality label Jan 8, 2019
@aeschli aeschli added this to the Backlog milestone Jan 8, 2019
@aeschli aeschli added the *out-of-scope Posted issue is not in scope of VS Code label Nov 6, 2020
@ghaschel
Copy link

This would be really useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code themes Color theme issues
Projects
None yet
Development

No branches or pull requests

5 participants
@alexdima @ghaschel @aeschli @0xc0 and others