Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

externalConsole: true does not open terminal, just hangs #6107

Closed
arve0 opened this issue May 4, 2016 · 7 comments
Closed

externalConsole: true does not open terminal, just hangs #6107

arve0 opened this issue May 4, 2016 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@arve0
Copy link

arve0 commented May 4, 2016

  • VSCode Version: 1.0.0
  • OS Version: osx 10.11.4

Steps to Reproduce:

  1. Create launch.json

    {
      "version": "0.2.0",
      "configurations": [
          {
              "name": "Launch",
              "type": "node",
              "request": "launch",
              "program": "${workspaceRoot}/dist/index.js",
              "stopOnEntry": false,
              "args": [],
              "cwd": "${workspaceRoot}/dist/",
              "preLaunchTask": null,
              "runtimeExecutable": null,
              "runtimeArgs": [
                  "--nolazy"
              ],
              "env": {
                  "NODE_ENV": "development"
              },
              "externalConsole": true,
              "sourceMaps": false,
              "outDir": null
          },
          {
              "name": "Attach",
              "type": "node",
              "request": "attach",
              "port": 5858,
              "address": "localhost",
              "restart": false,
              "sourceMaps": false,
              "outDir": null,
              "localRoot": "${workspaceRoot}",
              "remoteRoot": null
          }
      ]
    }
  2. Press F5.

What happens: Debug-bar shows. If one goes to debug view, a small dot moves left to right, above VARIABLES.

Expected: A terminal should open.

If I change externalConsole to false, I can debug as normal inside vscode, but without any stdin.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels May 5, 2016
@weinand
Copy link
Contributor

weinand commented May 9, 2016

@arve0 does it make a difference if you open the Terminal application first and then try to launch the debugging session?

@arve0
Copy link
Author

arve0 commented May 9, 2016

No, it's the same with Terminal open or closed.

@weinand
Copy link
Contributor

weinand commented May 9, 2016

@arve0 if the Terminal application is not running, does VS Code make the Terminal application start when launching a debug session?

@arve0
Copy link
Author

arve0 commented May 9, 2016

Not at the PC now, I'll have to check that later today.

@arve0
Copy link
Author

arve0 commented May 9, 2016

if the Terminal application is not running, does VS Code make the Terminal application start

No.

I've created a screen cast: https://youtu.be/xpZOi9hqT4M

Should also mention that I have a case sensitive file system. (You may notice that I'm using typescript 1.9.0-dev, ref #5161.)

@weinand
Copy link
Contributor

weinand commented May 9, 2016

@arve0 mentioning the case sensitive file system might have helped to find the problem: the node-debug extension references an AppleScript helper through a path with the wrong character case.

Could you please change the name of the Apple Script helper from TerminalHelper.scpt to terminalHelper.scpt. You can find the helper inside the VS Code application bundle:

/Applications/Visual\ Studio\ Code.app/Contents/Resources/app/extensions/node-debug/out/node/TerminalHelper.scpt

@weinand weinand added this to the May 2016 milestone May 9, 2016
@arve0
Copy link
Author

arve0 commented May 9, 2016

Sweet! That worked 🎉 Thanks.

@weinand weinand added the verified Verification succeeded label May 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants