Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strict null errors in 'vs/base/common/linkedList.ts' #60571

Closed
mjbvz opened this issue Oct 10, 2018 · 1 comment
Closed

Fix strict null errors in 'vs/base/common/linkedList.ts' #60571

mjbvz opened this issue Oct 10, 2018 · 1 comment
Assignees
Labels
engineering VS Code - Build / issue tracking / etc.

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Oct 10, 2018

Part of #60565

Tracks updating vs/base/common/linkedList.ts to have strict null checking. This file is heavily depended on and blocks enabling strictNullChecks in other files in common

Steps

  1. Add ./vs/base/common/linkedList.ts to the include section of src/tsconfig.strictNullChecks.json
  2. Run yarn strict-null-check -- --watch
  3. Fix strict null check compiler errors
  4. Verify normal build still works
@mjbvz mjbvz added the engineering VS Code - Build / issue tracking / etc. label Oct 10, 2018
@mjbvz
Copy link
Collaborator Author

mjbvz commented Oct 11, 2018

Handled by 740ac11

@mjbvz mjbvz closed this as completed Oct 11, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

No branches or pull requests

2 participants