Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go to definition doesn't work in jsdoc comments #59504

Closed
Tyriar opened this issue Sep 26, 2018 · 1 comment
Closed

Go to definition doesn't work in jsdoc comments #59504

Tyriar opened this issue Sep 26, 2018 · 1 comment
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 26, 2018

ctrl+click works but F12/right click go to def doesn't

image

Tested in vscode.d.ts
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues labels Sep 26, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Sep 27, 2018

Those links don't actually come from typescript but from our extension editing extension

The proper js doc way to express a reference is using the @link tag which we currently don't support: microsoft/TypeScript#16498

@mjbvz mjbvz closed this as completed Sep 27, 2018
@mjbvz mjbvz added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Sep 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tyriar @mjbvz