Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Select all occurrences of current selection"can not select the contents of more than 1000 rows. #5887

Closed
yisibl opened this issue Apr 27, 2016 · 5 comments
Closed

"Select all occurrences of current selection"can not select the contents of more than 1000 rows. #5887

yisibl opened this issue Apr 27, 2016 · 5 comments
Assignees
@alexdima
Labels
debt Code quality issues editor-find Editor find operations editor-multicursor Editor multiple cursor issues feature-request Request for new features or functionality verified Verification succeeded
Milestone
October 2017

Comments

@yisibl
Copy link
Contributor

yisibl commented Apr 27, 2016 •
edited
Loading

  • VSCode Version:1.0.0
  • OS Version: 10.11.4 (15E65)

Steps to Reproduce:

  1. Select a section of content
  2. ⇧⌘L
  3. Can not select the contents of more than 1000 rows
@jrieken jrieken assigned alexdima and unassigned jrieken Apr 27, 2016
@yisibl
Copy link
Contributor Author

yisibl commented Jun 8, 2016 •
edited
Loading

Who can help take a look?

I think it's a problem here:
https://github.com/Microsoft/vscode/blob/1.2.0/src/vs/editor/contrib/find/common/findModel.ts#L37

@yisibl yisibl mentioned this issue Jun 8, 2016
Closed
@alexdima
Copy link
Member

alexdima commented Aug 9, 2016

Related: #496

@alexdima
Copy link
Member

alexdima commented Aug 9, 2016

Related: #1110

@alexdima alexdima added the editor-find Editor find operations label Aug 9, 2016
@alexdima alexdima added this to the Backlog milestone Aug 9, 2016
@Bill-Stewart Bill-Stewart mentioned this issue Feb 21, 2017
Closed
@agauniyal
Copy link

1000 occurrences in a single file aren't too large, please raise the limit to somewhat reasonable number.

@alexdima alexdima added feature-request Request for new features or functionality editor-multicursor Editor multiple cursor issues labels Apr 11, 2017
@ToMakeSense ToMakeSense mentioned this issue Aug 10, 2017
Closed
@ToMakeSense ToMakeSense mentioned this issue Sep 2, 2017
Closed
@alexdima alexdima mentioned this issue Sep 28, 2017
Closed
@alexdima alexdima added the debt Code quality issues label Sep 28, 2017
This was referenced Sep 28, 2017
Closed
Closed
@alexdima alexdima modified the milestones: Backlog, October 2017 Oct 20, 2017
@alexdima
Copy link
Member

PR #36410 has made it feasible that we remove this limitation.

@alexdima alexdima mentioned this issue Oct 21, 2017
Closed
@email2vimalraj email2vimalraj mentioned this issue Oct 24, 2017
Closed
@alexdima alexdima added the verification-needed Verification of issue is requested label Oct 30, 2017
@mjbvz mjbvz added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Oct 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
debt Code quality issues editor-find Editor find operations editor-multicursor Editor multiple cursor issues feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Milestone
October 2017
Development

No branches or pull requests
5 participants
@jrieken @yisibl @alexdima @agauniyal @mjbvz