-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoClosingPairs in language-configuration.json doesn't allow multiple entries that use quotes. #58619
Comments
It looks like this is related to #72177, which is a slightly different issue but probably caused by the same underlying bug. |
This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation. Happy Coding! |
Since this is an extensibility issue, I find it hard to believe that this will get the required likes to not be closed. Please consider not doing that... This can be viewed as a bug (or at least a silly limitation) as I can have auto closing pairs of |
This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation. Happy Coding |
Pls no |
It's up to 25 votes now, so I think it's safe. But I agree with what you wrote in #91714 (comment) about how the autoclose process selects against extension-related issues since a lot fewer people experience them. |
🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation. Happy Coding! |
@TylerLeonhardt This works fine for me on latest VS Code. If I add:
to I believe this got addressed as a side effect of 37981d8 . Can you please confirm? |
Awesome - let me give this a test. Why was this closed? The change will need to be in this repo so that the maximum amount of people are affected (aka those that don't install the PowerShell extension but edit a PowerShell script). |
@TylerLeonhardt I closed the issue because I considered the initial issue is resolved. So now "autoClosingPairs in language-configuration.json does allow multiple entries that use quotes". Was this issue meant to be about PowerShell specifically? I thought that was given just as an example. Do you want that we add |
Thanks @alexdima, makes sense! Yes we should add those to the built-in PowerShell language configuration. I was about to send a PR your way 😄 |
I'm looking for a way to support autoClosingPair of:
' '
," "
,@' '@
, and@" "@
However, when I add, for example:
["@'","'@"]
to thelanguage-configuration.json
it doesn't work and still autocloses just'
so it looks like@''
.If I remove this entry from the autoClosingPairs, then
@'
closes properly to become@''@
. But then'
no longer completes.Is there a way to do what I'm trying to do?
The text was updated successfully, but these errors were encountered: