Extension is not deactivated on closing the editor window

[seanmcbreen]

From @ArtemGovorov on November 16, 2015 7:15

My extension spins up a few processes that I'd like to kill when it's deactivated.
The deactivation callback for ExtensionContext

context.subscriptions.push({dispose: () => ...});

works perfectly when I stop debugger for the Extension Development Host. However, if I just close the editor window on OSX, the deactivation callback is not invoked, so I can see all created processes hanging around and not being killed.

Copied from original issue: Microsoft/vscode-extensionbuilders#113

[seanmcbreen]

From @ArtemGovorov on November 16, 2015 7:34

Here's the workaround I use for now for OSX:

  process.on('SIGTERM', function () {
    // extension deactivation code
  });

[seanmcbreen]

From @bpasero on November 16, 2015 7:38

@ArtemGovorov is this only during extension development? Not when having the extension installed and closing the window?

[seanmcbreen]

From @ArtemGovorov on November 16, 2015 7:39

@bpasero Same for the installed extension (on OSX)

[seanmcbreen]

From @bpasero on November 16, 2015 8:2

@jrieken fyi that would be pretty bad, is the PH connected to the lifecycle service somehow?

[seanmcbreen]

From @egamma on November 16, 2015 8:7

@dbaeumer you shut down the language server on shutdown and it works correct?

[seanmcbreen]

From @dbaeumer on November 16, 2015 9:29

@egamma no, I currently fix this on the server side by observing the streams and exit the server is the input stream closes.

[daviwil]

See also: #537

[alexdima]

With 98473e0, VSCode's extension host will now call deactivate() if extensions export it and call dispose() on ExtensionContext.subscriptions on shutdown, then will wait 1s before exiting

[alexdima]

this was in the test plan