Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test built-in loaded scripts explorer #54921

Closed
1 task done
weinand opened this issue Jul 24, 2018 · 1 comment
Closed
1 task done

Test built-in loaded scripts explorer #54921

weinand opened this issue Jul 24, 2018 · 1 comment
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Jul 24, 2018

Refs: #37767

Complexity: 4

Authors: @weinand

We have started to move the LoadedScripts view from node-debug into VS Code core.

In addition we have improved the way how the tree of loaded scripts is built by hiding all intermediate folder nodes if they only have one child.

The new LoadedScripts view is only available in the aweinand/loadedscripts branch of VS Code.

Verify that:

  • loaded scripts are shown correctly for node-debug, node-debug2, chrome
  • multiple root folders are shown as an additional tree level if there are more than one
  • multiple debug sessions add an additional level to the tree (which is not removed if the number of sessions drops to one again)
  • the new algorithm for minimising the number of folders with one child works and is useful.
  • find everything that is missing from the new implementation that make the LoadedScripts view behave differently than the VS Code explorer. E.g. accessibility, etc.

As a starter test you can use the attached zip: loadedScripts.zip

  • unzip archive
  • open the "test" folder in VS Code and run the "Hello" launch config.
  • stepping through the program should make scripts appear in different sections of the tree
  • run the compound launch config to see multiple sessions in the tree
  • open the "scripts.code-workspace" file for a VS Code multi-root setup
  • another level of root folders should show up in the tree

@isidorn I've noticed that the loaded scripts view does no longer show up in the Insiders build. But my implementation only lives in the branch. Could it be that your initial implementation of the loaded scripts view broke the existing extension based implementation?

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item labels Jul 24, 2018
@weinand weinand added this to the July 2018 milestone Jul 24, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 31, 2018

@weinand loaded scripts shows up for me in the latest vscode insiders properly both for os x and linux. Can you verify if you are still seeing this with latest vscode insiders? I think I was also seeing this issue with insiders from last week - but seems to be fixed now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Development

No branches or pull requests

2 participants