Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of diagnotic hovers #54503

Open
felixfbecker opened this issue Jul 17, 2018 · 3 comments
Open

Improve readability of diagnotic hovers #54503

felixfbecker opened this issue Jul 17, 2018 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality languages-diagnostics Source problems reporting
Milestone

Comments

@felixfbecker
Copy link
Contributor

The number one annoyance I have and hear from people about VS Code + TypeScript is that type errors are hard to read. TypeScript will display nested type errors with each level indented, but because of the line wrapping, that indentation basically lost.
This makes the error hard to follow and in consequence hard to solve.

image

Here are things that I think would improve the readability:

  • Add an option to enable horizontal scrolling in hovers. This would mean the indentation would actually have the intended visual effect.
  • Make the width of the hover configurable. I have way more space on my screen it could utilize.
  • Add smart wrapping that preserves indentation.
  • Add markdown support to diagnostics and make TypeScript output markdown. This would mean not the whole diagnostic has to be rendered in a monospace font, therefor saving horizontal space. The parts that are code would use backticks instead of single quotes.
@vscodebot vscodebot bot added editor editor-autoindent Editor auto indentation issues labels Jul 17, 2018
@alexdima alexdima added editor-hover Editor mouse hover and removed editor editor-autoindent Editor auto indentation issues labels Jul 18, 2018
@joaomoreno joaomoreno assigned mjbvz and unassigned joaomoreno Jul 18, 2018
@joaomoreno
Copy link
Member

Hover has full Markdown support. TypeScript opts to spit everything out in monospace font, so it ends up like that.

@mjbvz
Copy link
Collaborator

mjbvz commented Jul 18, 2018

@joaomoreno This is coming from VS Code's built-in error hover support which I do not believe supports markdown. Even if problem hover did support markdown content, wider hovers content and proper wrapping would still be beneficial and cannot be addressed by the TypeScript extension

@joaomoreno joaomoreno added this to the Backlog milestone Jul 19, 2018
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Jul 19, 2018
@joaomoreno joaomoreno added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Sep 19, 2018
@joaomoreno joaomoreno removed their assignment Sep 19, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Feb 22, 2019

Expanding hovers was added with #67076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality languages-diagnostics Source problems reporting
Projects
None yet
Development

No branches or pull requests

7 participants