Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension debugging: Debugger stops but doesn't show call stack #5348

Closed
aeschli opened this issue Apr 15, 2016 · 7 comments
Closed

Extension debugging: Debugger stops but doesn't show call stack #5348

aeschli opened this issue Apr 15, 2016 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Apr 15, 2016

  • VSCode Version: alpha from 15-04
  • OS Version: Linux

Steps to Reproduce:

  1. In the vscode repo open /vscode/extensions/php as folder
  2. set a breakpoint on /src/features/hoverProvider.ts, line 13 (in provideHover)
  3. F5 to run the extension
  4. in the dev target open a PHP file and hover over a word
  5. Debugger stops, but call stack stays empty
@aeschli aeschli added electron-update bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Apr 15, 2016
@aeschli
Copy link
Contributor Author

aeschli commented Apr 15, 2016

This works in 1.0.0

@isidorn
Copy link
Contributor

isidorn commented Apr 15, 2016

VSCode is getting an empty callstack from node debug, forwarding to @weinand
I can also debug our nodeDebug next week to drill deeper.

@isidorn isidorn assigned weinand and unassigned isidorn Apr 15, 2016
@isidorn
Copy link
Contributor

isidorn commented Apr 20, 2016

Asigning to me to investigate

@isidorn isidorn assigned isidorn and unassigned weinand Apr 20, 2016
@isidorn isidorn added this to the April 2016 milestone Apr 20, 2016
@isidorn
Copy link
Contributor

isidorn commented Apr 22, 2016

The error that the node adapter gets from node is

message:"Internal error: illegal access"
request_seq:25
seq:155
success:false
type:"response"
__proto__:Object

It happens here
Not sure if related node-inspector/node-inspector#413
So it seems that the adapter has no access to the new node running as part of the extension host.

Will continue investigating, pasting info here maybe @weinand, @bpasero have a suggestion

@bpasero
Copy link
Member

bpasero commented Apr 22, 2016

I did not hear about this issue before. Unrelated: You should really find a way to return these errors back to the adapter and display them somehow, the error in https://github.com/Microsoft/vscode-node-debug/blob/master/src/node/nodeDebug.ts#L1527 seems totally not being used?

@isidorn
Copy link
Contributor

isidorn commented Apr 22, 2016

Can not reproduce this with a small node 5.10 attach sample. So somehow trying to attach to node inside extension host makes the difference here.
I do not believe this is important since this will not get surfaced to the users. Removing that tag, @aeschli let me know if you disagree.

@isidorn
Copy link
Contributor

isidorn commented Apr 26, 2016

Fixed this morning by Ben and me. Works for me now

@isidorn isidorn closed this as completed Apr 26, 2016
@isidorn isidorn assigned aeschli and unassigned isidorn Apr 28, 2016
@aeschli aeschli added the verified Verification succeeded label Apr 28, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants