Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test API for preselected items #52798

Closed
2 tasks done
jrieken opened this issue Jun 25, 2018 · 5 comments
Closed
2 tasks done

Test API for preselected items #52798

jrieken opened this issue Jun 25, 2018 · 5 comments

Comments

@jrieken
Copy link
Member

jrieken commented Jun 25, 2018

Refs: #35551

Complexity: 1

A completion item can not now be marked as preselected. That means the UI is more likely to select that item. 'More likely' because such items can still be filtered out or ranked low and then they aren't selected. Also, suggest memories overwrite the preselect-property. Test that all of that works.

@jrieken
Copy link
Member Author

jrieken commented Jun 25, 2018

FYI - to test against the latest API do the following:

  • open your extensions package.json file
  • change the engine.vscode property to *
  • run npm run postinstall (assuming you have the vscode module as dev-dependency)
  • undo the engine-version change from step 2

@jrieken
Copy link
Member Author

jrieken commented Jun 25, 2018

assigning @ramya-rao-a because of emmet

@jrieken jrieken added this to the June 2018 milestone Jun 25, 2018
@sandy081
Copy link
Member

@jrieken Do you mean can here - A completion item can not be marked as preselected.?

@sandy081 sandy081 removed their assignment Jun 26, 2018
@jrieken
Copy link
Member Author

jrieken commented Jun 26, 2018

ops. thanks @sandy081. corrected.

@ramya-rao-a
Copy link
Contributor

Verified that the pre-selected item is pre-selected when completion is triggered and there is no text before the cursor

@ramya-rao-a ramya-rao-a removed their assignment Jun 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants