Arrow navigation broken in "Search" panel

[martellaj]

Issue Type: Bug

NOTE: I have search in panel.

1. Open search, and focus is put in first input where search text goes.
2. Hit down arrow.

Expected (old behavior): Focus shifts to "files to include" input.
Actual: Nothing.

VS Code version: Code - Insiders 1.25.0-insider (8f8ed32, 2018-06-08T05:20:32.976Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (8 x 3600)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: disabled_software video_decode: enabled video_encode: enabled vpx_decode: enabled webgl: enabled webgl2: enabled
Memory (System)	31.79GB (12.16GB free)
Process Argv	C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe
Screen Reader	no
VM	0%

Extensions (12)

Extension	Author (truncated)	Version
snapshot-tools	asv	0.0.7
bracket-pair-colorizer	Coe	1.0.58
gitlens	eam	8.3.5
tslint	eg2	1.0.30
prettier-vscode	esb	1.5.0
sort-typescript-imports	mic	1.4.1
csharp	ms-	1.15.2
debugger-for-chrome	msj	4.5.0
polacode	pnp	0.2.2
project-snippets	reb	0.5.0
vscode-icons	rob	7.23.0
vscode-todo-highlight	way	0.5.12

(3 theme extensions excluded)

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Tab/keys navigation in Search panel (#37614)

[sandy081]

@martellaj This was due to the change of defaults

• Default shortcuts for History navigation in the input boxes are Up and Down arrows
• Default shortcuts for navigating among input boxes are cmd+Up Arrow and cmd+Down Arrow

Change was done because of this #12645. This made all our history navigation to be consistent and use Up and Down arrows.

You can always change the behaviour back by updating the keybindings to the following commands

Search Inputs navigation commands: search.focus.nextInputBox and search.focus.previousInputBox

Input history navigation commands: history.showPrevious and history.showNext

[martellaj]

@sandy081 Thanks for the explanation!