Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import quote style not respected on file move #50723

Closed
RMacfarlane opened this issue May 29, 2018 · 1 comment
Closed

Import quote style not respected on file move #50723

RMacfarlane opened this issue May 29, 2018 · 1 comment
Assignees
@mjbvz
Labels
*out-of-scope Posted issue is not in scope of VS Code typescript Typescript support issues

Comments

@RMacfarlane
Copy link
Contributor

Issue Type: Bug

Testing #50494

Repro steps:

  1. Set typescript.updateImportsOnFileMove.enabled to always and typescript.preferences.quoteStyle to single, no other modifications to typescript settings
  2. Have folder with files a.ts and b.ts, where b has import { FOO} from "./a" using latest typescript version
  3. Move a.ts

The quote style remains double quotes in the import statement. I think this is reasonable behavior, but from the test item text, it seems unexpected

VS Code version: Code - Insiders 1.24.0-insider (bfd155e, 2018-05-29T05:16:50.002Z)
OS version: Windows_NT x64 10.0.17134
@RMacfarlane RMacfarlane added the typescript Typescript support issues label May 29, 2018
@vscodebot vscodebot bot added the insiders label May 29, 2018
@vscodebot vscodebot bot removed the insiders label Jun 7, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Jun 25, 2018

I believe that preserving the quote style here is correct (or at least not wrong).

We can revisit this if we get more feedback

@mjbvz mjbvz closed this as completed Jun 25, 2018
@mjbvz mjbvz added the *out-of-scope Posted issue is not in scope of VS Code label Jun 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
*out-of-scope Posted issue is not in scope of VS Code typescript Typescript support issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RMacfarlane @mjbvz