Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose glyphMargin support to extensions #47559

Open
eamodio opened this issue Apr 10, 2018 · 9 comments
Open

Expose glyphMargin support to extensions #47559

eamodio opened this issue Apr 10, 2018 · 9 comments
Labels
api feature-request Request for new features or functionality
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented Apr 10, 2018

It would be great if extension were able to use the built-in glyphMargin decorations -- i.e. clickable decorations in the gutter.

@vscodebot
Copy link

vscodebot bot commented Apr 10, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@jrieken jrieken assigned alexdima and unassigned jrieken Apr 10, 2018
@jrieken jrieken added the api label Apr 10, 2018
@alexdima alexdima added the feature-request Request for new features or functionality label Apr 10, 2018
@alexdima alexdima added this to the Backlog milestone Apr 10, 2018
@alexdima alexdima removed their assignment Apr 17, 2018
@eamodio
Copy link
Contributor Author

eamodio commented Oct 18, 2018

Is this something a PR would be accepted for? /cc @jrieken

@jrieken
Copy link
Member

jrieken commented Oct 18, 2018

cc @alexandrudima

@alexdima
Copy link
Member

The glyph margin is problematic because we have potentially N decorations fighting for the rendering space of 1 decoration. It is unclear when N > 1 which of the decorations should win (in terms of rendering and of interaction).

@Relequestual
Copy link

What I would like to personaly see is the ability to modify the default click action (via settings of course).
I don't need click for breakpoint, but I WOULD like click to add bookmark.

@Relequestual
Copy link

It LOOKS like extensiosn CAN already put glyphs in the margin, so THAT isn't an issue anymore.

@connectdotz
Copy link

It LOOKS like extensiosn CAN already put glyphs in the margin, so THAT isn't an issue anymore.

@Relequestual can you share which api does this?

@alexdima alexdima removed their assignment Dec 3, 2020
@ppezaris
Copy link

The glyph margin is problematic because we have potentially N decorations fighting for the rendering space of 1 decoration. It is unclear when N > 1 which of the decorations should win (in terms of rendering and of interaction).

perhaps this could be solved with an indicator that there are multiple glyphs, and then when the mouse hovers over, fan them out so they can be selected individually. we actually implemented something like this in the Atom editor years ago and it worked out very well.

@eamodio
Copy link
Contributor Author

eamodio commented Jan 29, 2021

See #114776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

6 participants