Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-C doesn't terminate process in tmux inside VSCode terminal #46731

Closed
Mellbourn opened this issue Mar 27, 2018 · 7 comments
Closed

Ctrl-C doesn't terminate process in tmux inside VSCode terminal #46731

Mellbourn opened this issue Mar 27, 2018 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster terminal Integrated terminal issues

Comments

@Mellbourn
Copy link

Mellbourn commented Mar 27, 2018

I have the setup that was described by João Moreno (@joaomoreno) in his blog post https://medium.com/@joaomoreno/persistent-terminal-sessions-in-vs-code-8fc469ed6b41

However, it seems to me that Control-C does not work as good as it used to.

It is particularly noticeable when I run nodemon. When I run it in tmux in iTerm, I can exit the run without problem by using Control-C. If I run nodemon inside tmux inside VSCode, I cannot. Instead it just renders ^C in the terminal window.

Strangely, the problem is intermittent. Restarting VSCode sometimes help.

  • VSCode Version: 1.21.1 and 1.22.1-insiders b753213
  • OS Version: MacOS 10.13.3

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added the insiders label Mar 27, 2018
@vscodebot
Copy link

vscodebot bot commented Mar 27, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@Tyriar
Copy link
Member

Tyriar commented Mar 27, 2018

@joaomoreno @bpasero have you noticed ctrl+c not being responsive?

@Tyriar Tyriar self-assigned this Mar 27, 2018
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Mar 27, 2018
@bpasero
Copy link
Member

bpasero commented Mar 28, 2018

@Tyriar no never, works fine.

@joaomoreno
Copy link
Member

Same here.

@Tyriar
Copy link
Member

Tyriar commented Mar 28, 2018

@Mellbourn for macOS we just send the shell (tmux) ^C (SIGINT) and let it handle it how it sees fit. Perhaps this is something related to your environment since @bpasero and @joaomoreno both run this setup and see no issues?

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Mar 28, 2018
@Mellbourn
Copy link
Author

@Tyriar strange. Ok, I'll try to investigate further on my own, to figure out why it is happening. Thanks for your time!

@Tyriar Tyriar closed this as completed Mar 29, 2018
@Tyriar
Copy link
Member

Tyriar commented Mar 29, 2018

@Mellbourn let us know if you find out more info.

@vscodebot vscodebot bot locked and limited conversation to collaborators May 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

4 participants