Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postDebugTask is not called when the debug session is stopped #46688

Closed
sandy081 opened this issue Mar 27, 2018 · 8 comments
Closed

postDebugTask is not called when the debug session is stopped #46688

sandy081 opened this issue Mar 27, 2018 · 8 comments
Assignees
Labels
*caused-by-extension Issue identified to be caused by an extension info-needed Issue requires more information from poster

Comments

@sandy081
Copy link
Member

sandy081 commented Mar 27, 2018

Testing #45305

  • Clone vscode smoke test repo
  • Create following task
{
            "label": "start",
            "type": "shell",
            "command": "say start",
            "identifier": "start"
        }
  • Add the above task as postDebugTask to the launch Launch Program
  • Start Debugging and Stop Debugging

Post debug task start is not executed

@isidorn
Copy link
Contributor

isidorn commented Mar 27, 2018

This works fine for me
What happens if you simply run the task via Run Task command?
On what platform are you? Can you reproduce always? Are you doing something special?

screen shot 2018-03-27 at 15 32 23

@isidorn isidorn added the info-needed Issue requires more information from poster label Mar 27, 2018
@sandy081
Copy link
Member Author

sandy081 commented Mar 27, 2018

What happens if you simply run the task via Run Task command?

Works for me

On what platform are you?

Mac

Can you reproduce always?

Yes

Are you doing something special?

I do not think so. I also tried debugging a simple JS file and it didn't work for me

@isidorn
Copy link
Contributor

isidorn commented Mar 27, 2018

@sandy081 can you please put a breakpoint here and let me know if it gets hit?
Or ping me when you can so we do a skype call and I debug this on your machine since I can not repro.

@sandy081
Copy link
Member Author

Sure. Will ping you tomorrow

@sandy081 sandy081 self-assigned this Mar 27, 2018
@sandy081 sandy081 added this to the March 2018 milestone Mar 27, 2018
@sandy081
Copy link
Member Author

Assigning myself and to March for investigation tomorrow

@isidorn
Copy link
Contributor

isidorn commented Mar 28, 2018

This is happening because the VS live share extension seems to overwrite the launch.json and remove the postDebugTask from it.
VS Live share extension should respect the postDebugTask and not remove it

@rodrigovaras can you please open a VS live share issues so you can track this please.

@isidorn isidorn closed this as completed Mar 28, 2018
@isidorn isidorn added the *caused-by-extension Issue identified to be caused by an extension label Mar 28, 2018
@isidorn
Copy link
Contributor

isidorn commented Mar 28, 2018

@Tyriar Tyriar removed this from the March 2018 milestone Mar 30, 2018
@lostintangent
Copy link
Member

@sandy081 This has been resolved in the latest Live Share extension release. Let us know if this repros after you update. Thanks again for reporting it!

@vscodebot vscodebot bot locked and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*caused-by-extension Issue identified to be caused by an extension info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

4 participants