You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
emmet-helper getEmmetCompletionParticipants returns an any, and in the HTML code it is assumed to match the HTML and CSS perticipants.
That's very fragile.
Idealy, each mode (CSSMode, HTMLMode) interacts separately with the emmet helper.
Let each mode do the caching and pass in the triggerKind to the mode.
IMO for HTML we don't really need to do the caching. And in the long term I'd like to avoid the caching by improving the CSS parser.
The text was updated successfully, but these errors were encountered:
emmet-helper getEmmetCompletionParticipants returns an any, and in the HTML code it is assumed to match the HTML and CSS perticipants.
That's very fragile.
I also want to avoid the
any[]
in https://github.com/Microsoft/vscode/blob/666e95e8e7f679e23c0e42d86864cba4f2e00025/extensions/html-language-features/server/src/modes/languageModes.ts#L38Idealy, each mode (CSSMode, HTMLMode) interacts separately with the emmet helper.
Let each mode do the caching and pass in the triggerKind to the mode.
IMO for HTML we don't really need to do the caching. And in the long term I'd like to avoid the caching by improving the CSS parser.
The text was updated successfully, but these errors were encountered: