Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emmet-helper getEmmetCompletionParticipants should be typed #46634

Closed
aeschli opened this issue Mar 27, 2018 · 1 comment
Closed

emmet-helper getEmmetCompletionParticipants should be typed #46634

aeschli opened this issue Mar 27, 2018 · 1 comment
Assignees
Labels
debt Code quality issues emmet Emmet related issues
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Mar 27, 2018

emmet-helper getEmmetCompletionParticipants returns an any, and in the HTML code it is assumed to match the HTML and CSS perticipants.
That's very fragile.

I also want to avoid the any[] in https://github.com/Microsoft/vscode/blob/666e95e8e7f679e23c0e42d86864cba4f2e00025/extensions/html-language-features/server/src/modes/languageModes.ts#L38

Idealy, each mode (CSSMode, HTMLMode) interacts separately with the emmet helper.
Let each mode do the caching and pass in the triggerKind to the mode.
IMO for HTML we don't really need to do the caching. And in the long term I'd like to avoid the caching by improving the CSS parser.

@vscodebot vscodebot bot added the emmet Emmet related issues label Mar 27, 2018
@ramya-rao-a ramya-rao-a added this to the April 2018 milestone Mar 27, 2018
@ramya-rao-a ramya-rao-a added the debt Code quality issues label Mar 27, 2018
@ramya-rao-a
Copy link
Contributor

The move of emmet for css completions to the css extension didn't work out. See #29113 (comment) to learn more.

So now we have just the html extension providing emmet completions outside of emmet extension. See #28545 (comment) on why this isn't much useful.

Reverting the move of emmet html completions from html extension with c314388

Enabling css emmet completions in embedded css parts in html files with 79a2512

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues emmet Emmet related issues
Projects
None yet
Development

No branches or pull requests

2 participants