Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test large file tokenization/coloring optimization #46603

Closed
2 tasks done
rebornix opened this issue Mar 26, 2018 · 0 comments
Closed
2 tasks done

Test large file tokenization/coloring optimization #46603

rebornix opened this issue Mar 26, 2018 · 0 comments

Comments

@rebornix
Copy link
Member

rebornix commented Mar 26, 2018

Complexity: 2

Testing #45944

When opening a file, we will show the top of the document or the last viewed portion of the document. For former case, we always see colorful content as we do some warmup (tokenize the top of the document) in advance. However for the later one, we sometimes see white code (in dark theme) first and then they become colorful as the tokenization is not super fast.

Our optimization here is tokenizing the viewport when opening the file by guessing the initial state of tokenization. So it can be wrong at the very beginning and get corrected after a while.

Testers you may want to verify

  • The tokenization of the viewport can be wrong but when the whole tokenization process is done, all contents are in good state.
  • Make sure contents after the viewport are tokenized finally.
@Tyriar Tyriar removed their assignment Mar 27, 2018
@sbatten sbatten removed their assignment Mar 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants