Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review/comment API exploration #45945

Closed
rebornix opened this issue Mar 16, 2018 · 1 comment
Closed

Code review/comment API exploration #45945

rebornix opened this issue Mar 16, 2018 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Milestone

Comments

@rebornix
Copy link
Member

To support displaying code comments in the editor, we can leverage viewzone and overlay widget, but as our view components (like view lines, decorations) are absolutely positioned, we want to know the height of viewzone, to archive that

  • we can guess by the content. it has limitation as markdown content can contain images
  • render the overlay widget first, get its height, resize the viewzone and relayout the editor

The second one is how VSTS manages code comments in monaco editor right now, the experience looks smooth.

@rebornix rebornix added this to the March 2018 milestone Mar 16, 2018
@rebornix rebornix self-assigned this Mar 16, 2018
@jrieken
Copy link
Member

jrieken commented Mar 28, 2018

This could be a dupe of #3220

@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants