Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal Configuration #45326

Closed
M-Zuber opened this issue Mar 8, 2018 · 4 comments
Closed

Terminal Configuration #45326

M-Zuber opened this issue Mar 8, 2018 · 4 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label

Comments

@M-Zuber
Copy link

M-Zuber commented Mar 8, 2018

I would love to be able to store terminal configurations on a per project/global basis

As an example of where it can be useful, the current project I am working on contains a graphql api and frontend sites.
On startup of vscode, I always open at least three terminals to run: tests, the api, and the frontend.

This extension by @fabiospampinato works very well, and could possibly be a base to build on in order to get something like this into the core

@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Mar 8, 2018
@fabiospampinato
Copy link
Contributor

I think that integrating my extension into VSC itself, and possibly making it more powerful, would certainly improve the lives of some people.

But I would rather prefer if VSC took the opposite approach, instead of integrating extensions into core, write every non-core functionality as an extension.

@M-Zuber
Copy link
Author

M-Zuber commented Mar 8, 2018

I agree 💯 that it should be done as an extension, but there seem to be a slight difference as to how things that are considered part of the "core experience" are treated, as opposed to other features.
And in my opinion, this kind of functionality should be first class.

Another use case I thought of, is having terminals start with different values for environment variables. Using my example above, in the terminal for testing, I want NODE_ENV to be test, but for actually running the app I want it to be dev

@Tyriar
Copy link
Member

Tyriar commented Mar 8, 2018

I think this is a duplicate of #44302, there is actually a that was added which kind of does this now terminal.integrated.experimentalRestore. It was added in haste and there are many edge cases I didn't really consider.

@fabiospampinato you should probably sub and drop your thoughts on that issue, maybe this is something that should be left to an extension (by making the terminal API more powerful). I was actually going to tackle that in March but put it on hold as I need to do some thinking about it, how it interacts with tasks and debug and how to prevent annoying situations, for example: create 5 terminals against a folder, work on some other project for a week, open the folder and get 5 terminals restored. But it would be good to have some basic restoring if it won't get in the way, we certainly wouldn't want to add the complexity that this extension allows.

@fabiospampinato I definitely want to hear your thoughts on restoring splits, not sure if you've created an issue yet?

@Tyriar Tyriar closed this as completed Mar 8, 2018
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 8, 2018
@fabiospampinato
Copy link
Contributor

@M-Zuber I've opened an issue about environment variables.

@Tyriar I've opened an issue in Terminals' repo about adding support for split terminals, feel free to comment on that. I'm going to post my thoughts on the issue you linked.

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

3 participants