Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localResourceRoots should include extension folder in addition to workspace folder #44677

Closed
octref opened this issue Feb 27, 2018 · 4 comments
Closed
Assignees
Labels
api *as-designed Described behavior is as designed webview Webview issues

Comments

@octref
Copy link
Contributor

octref commented Feb 27, 2018

Testing #44466

Feel this is a saner default.

@octref octref added api webview Webview issues labels Feb 27, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Feb 28, 2018

Already covered by the vscode-extension-resource scheme. The vscode-extension-resource resources are always available regardless of the localResourceRoots setting

@mjbvz mjbvz closed this as completed Feb 28, 2018
@mjbvz mjbvz added the *as-designed Described behavior is as designed label Feb 28, 2018
@octref
Copy link
Contributor Author

octref commented Feb 28, 2018

vscode-extension-resource

Can we start a documentation for the Webview early? I'm happy to set up yet another preview server where the team can see early documentation and give feedback. It would be nice to see the API and the doc evolving together.

Now it seems impossible to figure out how to include external js/css files (the <base> thing we talked about and the CSP rules). I don't even know if @jrieken or @tsalinger were able to test including external js/css from extension folder.

@tsalinger
Copy link
Contributor

@octref good point! I was trying to include external js but didn't succeed.
In the meantime, Matt gave me some feedback on it and I'll try again later today.

@tsalinger
Copy link
Contributor

For the record: I didn't manage to include an external js file.
@mjbvz would be cool if you could add a minimal example on how to do it.

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api *as-designed Described behavior is as designed webview Webview issues
Projects
None yet
Development

No branches or pull requests

3 participants