Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the find-feature optional #44597

Closed
jrieken opened this issue Feb 27, 2018 · 1 comment
Closed

make the find-feature optional #44597

jrieken opened this issue Feb 27, 2018 · 1 comment
Assignees
@mjbvz
Labels
api on-testplan webview Webview issues
Milestone
March 2018

Comments

@jrieken
Copy link
Member

jrieken commented Feb 27, 2018

re #44466

I can imagine that not everyone wants/needs the find widget in the webview and like other options we should have an option that controls if a find widget is desired
@vscodebot vscodebot bot added editor editor-find Editor find operations labels Feb 27, 2018
@mjbvz mjbvz self-assigned this Feb 27, 2018
@mjbvz mjbvz added api webview Webview issues and removed editor-find Editor find operations editor labels Feb 27, 2018
@mjbvz mjbvz added this to the March 2018 milestone Mar 15, 2018
@mjbvz mjbvz closed this as completed in e839ec0 Mar 19, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 19, 2018

Added WebViewOptions.enableFindWidget. Defaults to false

@vscodebot vscodebot bot locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
api on-testplan webview Webview issues
Projects
None yet
Milestone
March 2018
Development

No branches or pull requests
2 participants
@jrieken @mjbvz