Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify/revisit Webview#uri #44575

Closed
jrieken opened this issue Feb 27, 2018 · 1 comment
Closed

Clarify/revisit Webview#uri #44575

jrieken opened this issue Feb 27, 2018 · 1 comment
Assignees
@mjbvz
Labels
on-testplan webview Webview issues
Milestone
March 2018

Comments

@jrieken
Copy link
Member

jrieken commented Feb 27, 2018 •
edited
Loading

re #44466

This doesn't seem like a natural fit and I wonder how it ended up in the proposed API
@octref
Copy link
Contributor

octref commented Feb 27, 2018

I agree it's confusing. First it differs from the old API in that it does not read the file content. Second it does not actually associate the webview with any resource so it's not a Resource Identifier.

@mjbvz mjbvz added this to the March 2018 milestone Feb 28, 2018
@mjbvz mjbvz added the webview Webview issues label Mar 1, 2018
@mjbvz mjbvz closed this as completed in ea1fed9 Mar 20, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
on-testplan webview Webview issues
Projects
None yet
Milestone
March 2018
Development

No branches or pull requests
3 participants
@jrieken @octref @mjbvz