Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webview is an editor-wannabe #44574

Closed
jrieken opened this issue Feb 27, 2018 · 4 comments
Closed

Webview is an editor-wannabe #44574

jrieken opened this issue Feb 27, 2018 · 4 comments
Assignees
@mjbvz
Labels
api on-testplan webview Webview issues
Milestone
March 2018

Comments

@jrieken
Copy link
Member

jrieken commented Feb 27, 2018 •
edited
Loading

re #44466

There is the onDidChangeActiveEditor vs onDidChangeActiveTextEdtor which is very confusing, then there is Webview#editorType which is also confusing and I don't understand why. Isn't a webview just a thing like a terminal or an output channel?
@jrieken
Copy link
Member Author

jrieken commented Feb 27, 2018 •
edited
Loading

Oh, it's actually not onDidChangeActiveTEXTeditor... Re-purposing this issue, updating description/title

@jrieken jrieken changed the title Proposed change to onDidChangeActiveEditor is a breaking change Webview is an editor-wannabe Feb 27, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Feb 27, 2018

See #43803 for the background and some of the other design options considered

@mjbvz mjbvz added api webview Webview issues labels Feb 27, 2018
@mjbvz mjbvz added this to the March 2018 milestone Feb 28, 2018
@jrieken
Copy link
Member Author

jrieken commented Feb 28, 2018

I believe it needs a new concept. Maybe something like const activePart: TextEditor | Webview | TreeView | OutputChannel | any;. We have similar requests already, folks want to know if focus is in a contributed tree, or they want to interact with an output channel. We should think about this in a wider scope.

@mjbvz
Copy link
Collaborator

mjbvz commented Mar 20, 2018

Made this event private with 27a1793. #45994 tracks the other parts of the new webview api proposal

@mjbvz mjbvz closed this as completed Mar 20, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
api on-testplan webview Webview issues
Projects
None yet
Milestone
March 2018
Development

No branches or pull requests
2 participants
@jrieken @mjbvz