Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BreakpointsChangeEvent doesn't contain the new location of breakpoint when newlines are added #44433

Closed
jramsay opened this issue Feb 26, 2018 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@jramsay
Copy link
Member

jramsay commented Feb 26, 2018

VSCode Version: 1.21.0-insider
OS Version: Windows 10 Enterprise
VS Live Share: 0.2.163

Scenario: a VS Live Share session between a host & a guest where they’re both editing a doc and configuring BPs before launching the debugger.

Steps:
• The host has existing BPs set and shares their project with the guest.
• The guest joins the session and adds a few new lines above a line with a BP and then edits the existing BP (ex: changes hit count from 1 to 4)

When the new line is added VS Live Share's breakpointManager's onDidChangeBreakpoints is triggered with a changed event. This changed event has the locations of the old breakpoints but does not appear to contain the new locations.

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues bug Issue identified by VS Code Team member as probable bug labels Feb 26, 2018
@weinand weinand added this to the March 2018 milestone Mar 6, 2018
@weinand weinand closed this as completed in 9389389 Mar 7, 2018
@roblourens roblourens added the verified Verification succeeded label Mar 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants