Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown show preview to side to does re-show an existing preview #44430

Closed
mjbvz opened this issue Feb 26, 2018 · 2 comments
Closed

Markdown show preview to side to does re-show an existing preview #44430

mjbvz opened this issue Feb 26, 2018 · 2 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues verification-found Issue verification failed verified Verification succeeded
Milestone
February 2018

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Feb 26, 2018 •
edited
Loading

Issue Type: Bug

  1. Open markdown preview to side.
  2. In second group, open a new editor so that the preview in a background tab
  3. Back in the original md document, run open preview to side again

Expected
Shows the existing webview.

Actual
Does not. Preview remains in background tab

Broken by #44307

VS Code version: Code - Insiders 1.21.0-insider (9031699, 2018-02-26T06:08:49.568Z)
OS version: Darwin x64 17.4.0

Reproduces only with extensions
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues labels Feb 26, 2018
@mjbvz mjbvz added this to the February 2018 milestone Feb 26, 2018
@mjbvz mjbvz self-assigned this Feb 26, 2018
@mjbvz mjbvz closed this as completed in 26cbbea Feb 26, 2018
@aeschli
Copy link
Contributor

aeschli commented Mar 1, 2018

I still see the bug in Version 1.21.0-insider
Commit 9a04587
Date 2018-03-01T06:47:39.037Z

markdown-opentoside

@aeschli aeschli reopened this Mar 1, 2018
@aeschli aeschli added the verification-found Issue verification failed label Mar 1, 2018
@mjbvz
Copy link
Collaborator Author

mjbvz commented Mar 1, 2018

Fixed by 02bd0a1

@mjbvz mjbvz closed this as completed Mar 1, 2018
@joaomoreno joaomoreno added the verified Verification succeeded label Mar 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues verification-found Issue verification failed verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
3 participants
@joaomoreno @aeschli @mjbvz