Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Alt+click to open alternative commands in context menu not working #44136

Closed
bpasero opened this issue Feb 21, 2018 · 3 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Feb 21, 2018

It looks like on Windows pressing Alt+right-click to e.g. bring up the "Delete Permanently" action is not working. When using it, the context menu does not show.

Could we possibly support the Shift+key too on Windows? I think we used to support that before, but not sure if now we have conflicts with multi-select?

/cc @dbaeumer

@isidorn fyi this only reproduces on a real Windows machine, not VM.

@isidorn
Copy link
Contributor

isidorn commented Feb 27, 2018

@jrieken do you mind if I start supporting shift for alternative commands on windows. The issue with alt is that it triggers the menu.
@bpasero this should not conflict with multi select since triggering the context menu does not affect multi selection. Also the right click does not affect multi selection

@jrieken
Copy link
Member

jrieken commented Feb 28, 2018

do you mind if I start supporting shift for alternative commands on windows.

Yeah, I would mind because it will break existing behaviour. It's also the alternative command, not a modification of an command. I would not mind adding shift in addition to alt on windows .

@isidorn
Copy link
Contributor

isidorn commented Feb 28, 2018

@jrieken what I meant in my original comment is to support both. Glad you are +1 for that.

@isidorn isidorn added feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Feb 28, 2018
@bpasero bpasero added the verified Verification succeeded label Mar 1, 2018
@isidorn isidorn added the release-notes Release notes issues label Mar 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants