WorkspaceEdit: applying edits before and after rename duplicates resource

[aeschli]

Testing #42334

Run the extension below.

• it does some edits to the document in the current editor
• renames the document (adds a _ to the name)
• it does some edits to the renamed document

You end up with 2 files.

'use strict';
// The module 'vscode' contains the VS Code extensibility API
// Import the module and reference it with the alias vscode in your code below
import * as vscode from 'vscode';
import * as path from 'path';

export function activate(context: vscode.ExtensionContext) {
    let disposable = vscode.commands.registerCommand('extension.sayHello', () => {
        let editor = vscode.window.activeTextEditor;
        if (editor) {
            let doc = editor.document;
            let docUri = doc.uri;
            let newUri = nameWithUnderscore(docUri);

            let we = new vscode.WorkspaceEdit();
            we.insert(docUri, new vscode.Position(0, 0), 'Hello');
            we.insert(docUri, new vscode.Position(0, 0), 'Foo');
            we.renameResource(docUri, newUri);
            we.insert(newUri, new vscode.Position(0, 0), 'Bar');

            console.log(JSON.stringify(we.allEntries(), null, '\t'));
            

            vscode.workspace.applyEdit(we);
        }
    });

    context.subscriptions.push(disposable);
}

function nameWithUnderscore(uri: vscode.Uri) {
    let uriPath = uri.fsPath;
    return vscode.Uri.file(path.join(path.dirname(uriPath), '_' + path.basename(uriPath)));
}

[aeschli]

The edit on the renamed doc is not necessary to reproduce the issue . All that's needed it a edit and a rename:

'use strict';
import * as vscode from 'vscode';
import * as path from 'path';

export function activate(context: vscode.ExtensionContext) {
    let disposable = vscode.commands.registerCommand('extension.sayHello', () => {
        let editor = vscode.window.activeTextEditor;
        if (editor) {
            let doc = editor.document;
            let docUri = doc.uri;
            let newUri = nameWithUnderscore(docUri);

            let we = new vscode.WorkspaceEdit();
            we.insert(docUri, new vscode.Position(0, 0), 'Hello');
            we.renameResource(docUri, newUri);

            console.log(JSON.stringify(we.allEntries(), null, '\t'));    

            vscode.workspace.applyEdit(we);
        }
    });

    context.subscriptions.push(disposable);
}

function nameWithUnderscore(uri: vscode.Uri) {
    let uriPath = uri.fsPath;
    return vscode.Uri.file(path.join(path.dirname(uriPath), '_' + path.basename(uriPath)));
}

[jrieken]

Similar as before... I see the tab as 'deleted from disk'