Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkspaceEdit: Clarify how operations on same URI are applied #42631

Closed
aeschli opened this issue Jan 31, 2018 · 0 comments
Closed

WorkspaceEdit: Clarify how operations on same URI are applied #42631

aeschli opened this issue Jan 31, 2018 · 0 comments
Assignees
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Jan 31, 2018

Testing #42334

WorkspaceEdits now can also express resource, creation, renames and deletes. An interesting aspect is how operations on the same resource are handled.
E.g. edits followed by renames followed by more edits
The API spec mentions something about grouping of edits for the same resource.
Not really clear to me what happens with:
edit resA, rename resA -> resB, create resA, set resA

In order to keep things well defined, I'd suggest to always collect the changes in the order they were announced and apply them exactly the same way.

@aeschli aeschli changed the title WorkspaceEdit: Simplify how operations on same URI are applied WorkspaceEdit: Clarify how operations on same URI are applied Jan 31, 2018
@jrieken jrieken added this to the January 2018 milestone Jan 31, 2018
@jrieken jrieken modified the milestones: January 2018, February 2018 Feb 1, 2018
@jrieken jrieken modified the milestones: February 2018, March 2018 Feb 27, 2018
@jrieken jrieken removed this from the March 2018 milestone Mar 8, 2018
@jrieken jrieken added this to the June 2018 milestone Jun 21, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants