Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open to the Side does not work when a folder is part of the multiselect #42584

Closed
RMacfarlane opened this issue Jan 31, 2018 · 2 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone

Comments

@RMacfarlane
Copy link
Contributor

Testing #41473

Repro steps:
Select a folder and file in the explorer, use menu or keyboard shortcut to run Open to the Side

Pane blinks in and out of existence

Would expect either all files within the folder to be opened, or the option to be disabled when a folder is selected

@RMacfarlane RMacfarlane assigned isidorn and unassigned bpasero Jan 31, 2018
@bpasero bpasero added the file-explorer Explorer widget issues label Jan 31, 2018
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Jan 31, 2018
@isidorn isidorn added this to the January 2018 milestone Jan 31, 2018
@isidorn
Copy link
Contributor

isidorn commented Jan 31, 2018

@RMacfarlane nice catch
@chrmarti how come the bot prematurly assigned @bpasero if there is a timeout now?

@isidorn
Copy link
Contributor

isidorn commented Jan 31, 2018

Now I simply ignore the selected folder when opening to the side.
I do not want to open all the children since this can be surprisin to users and in that case you could argue that we should show open to the side even if only one folder is selected.

Open To The Side is disabled when the focused element is a folder, and all our disablement is working in the context of the a focused element, not in the context of what is all selected.

Due to the reasons mentioned above I have chosen to simply ignore the selected folders when executing this commands.

@bpasero bpasero added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants