Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Bracketed property completions #42370

Closed
1 task done
mjbvz opened this issue Jan 29, 2018 · 0 comments
Closed
1 task done

Test: Bracketed property completions #42370

mjbvz opened this issue Jan 29, 2018 · 0 comments

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 29, 2018

#36429

Complexity: 1

OS:

Summary

TS can now suggestion properties that require bracket accessors, such as properties with whitespace or 🦄 in their names. Accepting once of these properties should automatically inserts a bracketed property accessor

Testing

  1. In a js project

  2. Create an object that has keys that are not normal JS identifiers

    const z = {
        'sp ace': 1
    }
  3. Trigger suggestions by typing z.

    • ✅ You see sp ace listed as a suggestion
  4. Accept this suggestions

    • ✅ Bracket property accessor is inserted: z['sp ace']

Other things to try

  • Try coming up with other property names that contain fun unicode characters

  • Try this for methods method names

@bpasero bpasero added this to the January 2018 milestone Jan 30, 2018
@gushuro gushuro removed their assignment Jan 31, 2018
@gushuro gushuro closed this as completed Jan 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants