Tab shrink: further reduce padding when close button is left

[roblourens]

Testing #39331

It feels like the tabs under "shrink" take up a lot of space for the amount of text you get. I think it's the same amount of padding as the full width tabs, but maybe it could be tightened up for smaller tabs?

[roblourens]

Actually I realize that's with tabCloseButton: left. On the right,

I can see much more. The text is going all the way to the edge with the close button on the right.

[bpasero]

Yeah I can see if I can also tweak the layout if the button is on the other side.

[bpasero]

I am actually not sure what to do here. If someone has an idea with a reasonable (ideally CSS only) PR, let me know.

[joshunger]

I sent you a PR to always reduce it on the left. Is this what you wanted?

This is what is looks like -

However, the welcome tab feels a little tight -

[bpasero]

@joshunger I think what I would expect as solution is the same thing we do for the close button when "workbench.editor.tabSizing": "shrink" is configured and the close button is on the right:

[joshunger]

@bpasero Got it. I'm assuming you want it to overlay the icon? Anything else I need to know?

[joshunger]

@bpasero do you have a claim bot so contributors can claim issues? How do you know who is working on it if it is labeled help-wanted?

[bpasero]

@joshunger yeah I would say overlay anything that is at that location, keep in mind that icons can also be turned off.

There is no "claiming" of issues so far, but agree it would be useful.

[joshunger]

Thought this was cool https://github.com/devtools-html/debugger.html/blob/master/docs/issues.md#claiming-issues

[vscodebot]

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!