Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paths in Debug Console output are not linked #39063

Closed
DanTup opened this issue Nov 23, 2017 · 2 comments
Closed

Paths in Debug Console output are not linked #39063

DanTup opened this issue Nov 23, 2017 · 2 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)

Comments

@DanTup
Copy link
Contributor

DanTup commented Nov 23, 2017

Raised in Dart-Code/Dart-Code#451; filenames in the debug console don't seem to be being linked. I've tried a bunch of different formats/categories to try and make this work, but none seem to:

this.sendEvent(new OutputEvent(`Danny3 (lib/test.dart:1:1)\n`, "stdout"));
this.sendEvent(new OutputEvent(`Danny3 (lib/test.dart:1:1)\n`, "console"));
this.sendEvent(new OutputEvent(`Danny3 (lib/test.dart:1:1)\n`, "stderr"));
this.sendEvent(new OutputEvent(`Danny3 lib/test.dart:1:1\n`, "stdout"));
this.sendEvent(new OutputEvent(`Danny3 lib/test.dart:1:1\n`, "console"));
this.sendEvent(new OutputEvent(`Danny3 lib/test.dart:1:1\n`, "stderr"));
this.sendEvent(new OutputEvent(`Danny3 ./lib/test.dart:1:1\n`, "stdout"));
this.sendEvent(new OutputEvent(`Danny3 ./lib/test.dart:1:1\n`, "console"));
this.sendEvent(new OutputEvent(`Danny3 ./lib/test.dart:1:1\n`, "stderr"));

screen shot 2017-11-23 at 22 11 41

The file does exist relative to the workspace root, though from what I've read in related cases, it seems that you no longer do fs.stat when deciding to link. I've found many cases suggesting there have been improvements/fixes to this and screenshots showing it working, so I'm not sure what's different about ours.

Are the rules about what formats are detected documented anywhere for me to check? If not, what's the best way to debug?

@vscodebot vscodebot bot added the debug Debug viewlet, configurations, breakpoints, adapter issues label Nov 23, 2017
@weinand weinand assigned isidorn and unassigned weinand Nov 23, 2017
@isidorn
Copy link
Contributor

isidorn commented Nov 24, 2017

Hey @DanTup yeah the file detection is not in the best shape and I will close this as a duplicate of the file detection umbrela item. #34026
In the meantime here's a code pointer and we accpet PRs that improve this
You can always put a breakpoint there and check what is going on
https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/debug/browser/linkDetector.ts#L13

@isidorn isidorn closed this as completed Nov 24, 2017
@isidorn isidorn added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 24, 2017
@DanTup
Copy link
Contributor Author

DanTup commented Nov 24, 2017

Cool thanks; I found a bunch of cases suggesting it should all work but didn't come across that one.

Also consider a way for extensions to contribute link detection rules

That would solve another issue I have too! :-)

I'll see if I can find some time to dig into why the simple case isn't working for us currently. Thanks!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants