Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose additional styles when crafting a custom theme #38990

Closed
johnpapa opened this issue Nov 23, 2017 · 2 comments
Closed

Expose additional styles when crafting a custom theme #38990

johnpapa opened this issue Nov 23, 2017 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality themes Color theme issues

Comments

@johnpapa
Copy link

As per conversation with @chrisdias and @seanmcbreen , here is a list of style settings I'd love to see exposed in VS Code.

Font settings for the VS Code Shell

The font-family for the shell itself, so we can change the title bar, sidebar, status bar, file tabs, and more. This would be the default for the shell and help match the code.

.monaco-shell {
  font-family: 'Operator Mono', 'Fira code', 'Inconsolata', monospace;
  letter-spacing: 0.5px;
}

Selection Highlight and Find Match

Expose border, and background for selectionHighlight and findMatch

image

/*
  This puts a thin yellow border around the found items like Sublime did it
*/
.monaco-editor .findMatch,
.monaco-editor .selectionHighlight {
  border-top: 0.1px solid #f7ecb5;
  border-bottom: 0.1px solid #f7ecb5;
  background: transparent;
}

Panel headers

Expose the color, font settings and letter spacing for the panel header titles. Letter spacing is sometimes needed as the titles' letters are very close and more difficult to read in some fonts.

.vs-dark .monaco-panel-view .panel > .panel-header > .title {
  font-weight: normal;
  letter-spacing: 1px;
}

Window titles

Expose color, font settings, and letter spacing for window titles

.vs-dark .monaco-workbench > .part.titlebar > .window-title {
  color: #fafafa;
  letter-spacing: 1px;
  font-weight: 200;
}

File Tabs

Expose color, font settings, and letter spacing for tabs (file tabs)

image

.monaco-workbench .tabs-container .tab * {
  font-style: italic;
}

Debug bar

Expose the border for the debug bar. I find this helps make it stand out, kinda like the border for peek view.

image

.vs-dark .monaco-workbench .debug-actions-widget {
  border-top: 1px solid #b15a91;
  border-bottom: 1px solid #b15a91;
}

Git Diffs

Expose the margin, border, box shadow and background color for the git diff indicators. We currently have the background color, but the others are not. This would allow a cool effect like this:

image

.monaco-editor .dirty-diff-added {
  margin-left: 16pt;
  box-shadow: -4pt 0 4pt 2pt #27ff00;
  border-left: 4pt solid #00ff00;
  background-color: #00ff00;
}

.monaco-editor .dirty-diff-modified {
  margin-left: 16pt;
  box-shadow: -4pt 0 4pt 2pt #4fb4d8;
  border-left: 4pt solid #4fb4d8;
  background-color: #4fb4d8;
}
@vscodebot vscodebot bot added the workbench label Nov 23, 2017
@bpasero bpasero added feature-request Request for new features or functionality themes Color theme issues and removed workbench labels Nov 23, 2017
@aeschli
Copy link
Contributor

aeschli commented Nov 23, 2017

@johnpapa Thanks for the suggestion and the nice screenshots and examples.
To be able to act on this we need separate issues. Each one has its own challenges and not all are within reach.
Font theming is #26128
Selection highlight and find borders is #30793

@johnpapa
Copy link
Author

Moved to ...

#30793

#39324

#26128

#39325

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality themes Color theme issues
Projects
None yet
Development

No branches or pull requests

3 participants